Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When galaxy redirects to CILogon, it passes a query parameter called idphint which is usually a url starting with https://.
Starting at 24.1 the axios calls in the ExternalLogin.vue were changed to use withPrefix from utils/redirect.ts. The problem is that this strips all double slashes, invalidating any protocol passed as parameters (
https://
becomeshttp:/
)I added a test to ensure that CILogon redirects are done correctly and changed the regex to only match duplicate slashes that are not preceded by a colon.
How to test the changes?
(Select all options that apply)
License